Repository navigation
Establish the AI-first base for developerz-ai/mini - #40
Conversation
Dz-Task-Id: tsk_0a0ad43b121f9de3db03300d21a3dd28
🟡 Reviewed1 actionable comment(s) · grounded on your code 🤖 developerz.ai — automated review, running on your model and your box. |
There was a problem hiding this comment.
Review summary — 19 file(s), 7 finding(s).
Critical 0 · Major 1 · Minor 6 · Nit 0
bin/check's new gate is sound, but the scaffolding overclaims: verify-change reserves exit codes 75/79 bin/check never emits, claims CI and the pre-commit hook run it when neither does at head, and .gitignore omits .env though .env.example says to create it and never commit it.
| File | Findings |
|---|---|
.claude/skills/verify-change/SKILL.md |
1 major, 2 minor |
.env.example |
1 minor |
.gitignore |
1 minor |
.mcp.json |
1 minor |
bin/check |
1 minor |
- test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against
🤖 developerz.ai review — automated, running on your model and your box. What is this?
|
Address review findings on #40
Work landed on #40 — watching it toward merge. 11m · 16 tool calls · 10 messages 🤖 developerz.ai, an automated agent, not a human — developerz-ai[bot] |
|
A fix round is working on this pull request. Nothing is needed from you right now.
Status for head 🤖 Posted by developerz.ai — an automated agent, not a human. |
Follow-up intent: Address review findings on #40 Dz-Task-Id: tsk_ed0f78f84275f57011186c26f0626b51
There was a problem hiding this comment.
Review summary — 5 file(s), 1 finding(s).
Critical 0 · Major 0 · Minor 1 · Nit 0
Security verdict: no widening — the increment only closes the previously flagged secret-handling gaps (.env now ignored, MCP env names documented in .env.example) and hardens the gate's exit contract; one issue found: a docs claim that CI grades the gate scripts bin/check now covers.
1 non-blocking finding(s) below major (no thread on a re-review — only blocking findings open threads)
.claude/skills/verify-change/SKILL.md:12minor · docs The reword says CI runs the same commands, but bin/check now guards five gate scripts (bin/setup, bin/dev, bin/check, bin/stop, .githooks/pre-commit) missing from CI's bash -n/shellcheck lists (per CLAUDE.md), so green CI no longer grades the gate scripts. Qualify the claim here or extend the workf…
- test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against
🤖 developerz.ai review — automated, running on your model and your box. What is this?
This pull request establishes the base an AI coding agent needs to work well in
developerz-ai/mini.Stack
The account's model ran this repository and answered its stack: Bash + ShellCheck.
Established
bin/setup— 4. scripts that workbin/dev— 4. scripts that workbin/check— 4. scripts that workbin/stop— 4. scripts that work.claude/agents/model-selection.md— 2. a specialist roster.claude/agents/doctor-checks.md— 2. a specialist roster.claude/agents/ollama-server.md— 2. a specialist roster.claude/agents/opencode-config.md— 2. a specialist roster.claude/skills/verify-change/SKILL.md— 3. project skills.claude/skills/model-registry/SKILL.md— 3. project skills.claude/skills/platform-module/SKILL.md— 3. project skills.claude/skills/new-tool/SKILL.md— 3. project skills.env.example.githooks/pre-commit— 4. scripts that work.gitignore.mcp.json— 5. agent wiring.dz/maintainer/reviewer.md— 0. the repo policy.dz/onboarding/scorecard.mdLeft alone
These already existed and are yours — nothing here was rewritten, reordered or reflowed:
CLAUDE.md— 1. a brainAGENTS.mddocs/README.md.claude/commands— 9. workflow commands.github/workflows/ci.yml— 4. scripts that work.dz/maintainer/maintainer.yml— 0. the repo policyVerification
The gate this pull request declares, run on the box that wrote it:
bin/setupthenbin/check, before these changes (base) and after them (head); thenbin/stop, the teardown the platform runs when every session ends; thenbin/setupandbin/stoponce more on the same box (reuse), the way every later session meets it.Proof: proved — every command ran green at head.
Scorecard
13 of 15 items ok. The whole card, with every piece of evidence, is
.dz/onboarding/scorecard.md.policy— ok — .dz/maintainer/maintainer.yml already present, left alonebrain— ok — CLAUDE.md already present, left aloneroster— ok — .claude/agents/model-selection.md establishedskills— ok — .claude/skills/verify-change/SKILL.md establishedscripts— ok — bin/setup establishedwiring— ok — .mcp.json establishedcommands— ok — .claude/commands already present, left aloneaccess— gap — landed 0 of 1 askedlayout— gap — partial house layoutsmoke_test— ok — tests/test_provider.sh in the repositoryenv_example— ok — .env.example establishedagents_md— ok — AGENTS.md already present, left aloneper_workspace_brains— ok — single-package repository: 0 workspacesdocs_readme— ok — docs/README.md already present, left alonegate_proved— ok — ./bin/check exited 0 at head (86.3s)First tasks
Queued from what this pass found, and none of them runs before this merges:
Merging
This rewrites how agents read your repo, on a repo the platform has not worked before,
so it is yours to merge — not the bot's. Merging it is also what marks the repo
onboarded; until then coding tasks on it are held (issue triage, PR review and
report-only tasks are unaffected).
🤖 Opened by developerz.ai, an automated agent, not a human, on developerz-ai/mini.
Raised automatically by a developerz.ai maintainer lane, from an interactive repository setup session.